deps/emscripten: Add support for dwp files in wasm builds #39707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Also, install before `proxy-wasm-cpp-sdk` to ensure it is used/patched Currently its installed after making our setup redundant Signed-off-by: Ryan Northey <[email protected]>
phlax
changed the title
proxy-wasm-cpp-sdk to ensure it is …
|
cc @krinkinmu |
agrawroh
approved these changes
Jun 2, 2025
repokitteh-read-only
bot
removed
the
deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, install before
proxy-wasm-cpp-sdkto ensure it is used/patchedCurrently its installed after, making our setup redundant
includes patch of emscripten-core/emsdk#1531
the context for this is that its required to use a hermetic llvm toolchain (other than being generally useful)
without it, redundant hackery/patching would be required as the newer platforms way of setting up toolchains expects something to be setup for various bins. Rather than adding a stub i figured add the fix. This has historically been the main blocker to adding llvm toolchains, or using the bazel platforms setup