[mdns]: Prepare for release v1.9 #899
Conversation
david-cermak
force-pushed
the
feat/mdns_fuzzer
branch
from
fa146ab to
2fe7b72
Compare
david-cermak
force-pushed
the
feat/mdns_fuzzer
branch
2 times, most recently
from
b979956 to
f07f344
Compare
david-cermak
force-pushed
the
feat/mdns_fuzzer
branch
from
8454450 to
2e433aa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on October 20
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| { | ||
| if (mdns_service_add(NULL, service_name, proto, port, NULL, 0)) { | ||
| // This is expected failure as the service thread is not running | ||
| return ESP_FAIL; |
There was a problem hiding this comment.
Bug: MDNS Tests Fail Without Action Execution
The mdns_test_sub_service_add and mdns_test_service_add functions removed the mdns_test_execute_action calls. These calls were essential for simulating service registration in the test environment, where mdns_service_add is expected to fail. Without them, subsequent checks (e.g., mdns_test_mdns_get_service_item) will always fail, and subtype additions may not be properly tested.
1 participant
Mostly about adding tests and features from the refactor PR