fix(websocket): fix relying on asprintf() to NULL strp on failure #901
+26
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
asprintf()'s return value:
When successful, these functions return the number of bytes
printed, just like sprintf(3). On error, -1 is returned, errno is
set to indicate the error, and the contents of strp are undefined.
Fixes the following:
error: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]
bryghtlabs-richard
force-pushed
the
fix/websocket-asprintf-ret-checks
branch
from
dbce2fe to
54eb002
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes "error: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Werror=unused-result]"
Related
Blocking CI run of #715
Testing
I don't have a great way to test this - it's a fix to allocation failure handling, but those allocation failures don't often occur on our products.
On the current FreeRTOS + newlib-libc, failing asprintf() sets strp=NULL, so this patch isn't expected to have a functional impact today, just fix the compiler errors and would improve portability on potential future platforms.
I did test by backporting and flashing onto our products - no functional impact.
Checklist
Before submitting a Pull Request, please ensure the following: