Added option to open Bangle.js emulator inside and outside #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added option to open the emulator window inside or as popup window (as already existed / default option).
The inside window can be moved around (draggable). Unfortunately, resizing in not stable.
ps 1: Just a suggestion, we should have some linter and prettier so all the code has same format and error free (as possible).
ps 2: I have an error with "npm start" when clicking in "sending to espruino". I develop this with "npm run web", please test on your side if this works with "npm start".
Question: Where are you going with this editor? Are you planning to evolve it or is to be replaced in a near future?