This repository was archived by the owner on Apr 11, 2021. It is now read-only.
types: fix enums to match batch submitter #145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires changes in the contracts, so don't merge for now |
|
Is this stale, should we close? If not, the changes in the contracts do not seem to be tracked anywhere. Are we working on getting that change in the contracts? |
|
The plan is to move forward with this instead: ethereum-optimism/contracts#300 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the enum for the Canonical Transaction Chain transactions so it matches what is in the batch submitter and in the contracts.
See:
https://github.com/ethereum-optimism/optimism-monorepo/blob/a37b46f6ffa9a7868d449c3bb4b067cd9bf64c29/packages/batch-submitter/src/coders/ecdsa-coder.ts#L17
https://github.com/ethereum-optimism/contracts-v2/blob/96baeba3feabdac09c9d9dd121c31bc2d2b63e7e/contracts/optimistic-ethereum/libraries/codec/Lib_OVMCodec.sol#L36
Contributing Agreement