This repository was archived by the owner on Apr 11, 2021. It is now read-only.
feat: reorgs first pass #271
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ben-chain
reviewed
Mar 26, 2021
| @@ -66,7 +66,8 @@ func run(evm *EVM, contract *Contract, input []byte, readOnly bool) ([]byte, err | |||
| } else { | |||
| log.Debug("Calling Known Contract", "ID", evm.Id, "Name", name, "Method", method.RawName) | |||
| if method.RawName == "ovmREVERT" { | |||
| log.Debug("Contract Threw Exception", "ID", evm.Id, "asciified", string(input)) | |||
| hex := hexutil.Encode(input) | |||
There was a problem hiding this comment.
FWIW I intentionally put this as asciified and not hex because it is usually a solidity revert string which is readable ascii. @smartcontracts and I ran into a case the other day where we wanted raw hex though, could be worth having both.
There was a problem hiding this comment.
I noticed it printing garbage characters so there must be a case where it does not include ascii
There was a problem hiding this comment.
It prepends the methodID hash for Error(string), so there are consistently those garbage characters at the front. There are definitely cases where there will be raw hex here but almost all normal contract reversions will be ascii. I'd recommend that we have both.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP: reorgs
Metadata
Fixes
Contributing Agreement