feat: L2ToL2CDM SentMessage originContext #15844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l2tol2cdm.sentmessage.ctx
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15844 +/- ##
===========================================
- Coverage 46.86% 45.99% -0.87%
===========================================
Files 1338 1283 -55
Lines 108127 103891 -4236
===========================================
- Hits 50672 47788 -2884
+ Misses 53847 52630 -1217
+ Partials 3608 3473 -135
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
hamdiallam
commented
May 12, 2025
| @@ -55,17 +55,12 @@ contract L2ToL2CrossDomainMessenger is ISemver, TransientReentrancyAware { | |||
| bytes32 internal constant CROSS_DOMAIN_MESSAGE_SOURCE_SLOT = | |||
| 0x711dfa3259c842fffc17d6e1f1e0fc5927756133a2345ca56b4cb8178589fee7; | |||
|
|
|||
| /// @notice Event selector for the SentMessage event. Will be removed in favor of reading | |||
There was a problem hiding this comment.
no longer needed with the merged bugfix
hamdiallam
commented
May 12, 2025
| /// @return Hash of the encoded message parameters, used to uniquely identify the message. | ||
| function hashL2toL2CrossDomainMessage( | ||
| uint256 _destination, | ||
| uint256 _source, | ||
| uint256 _nonce, | ||
| address _sender, | ||
| address _target, | ||
| bytes memory _message | ||
| bytes memory _message, | ||
| bytes memory _context |
There was a problem hiding this comment.
critical to include here so that resendMessage works as intended
tynes
reviewed
May 12, 2025
| @@ -16,7 +16,7 @@ import { ISuperchainTokenBridge } from "interfaces/L2/ISuperchainTokenBridge.sol | |||
| /// @notice Integration test that checks that the `ExecutingMessage` event is emitted on crosschain mints. | |||
| contract ExecutingMessageEmittedTest is CommonTest { | |||
| bytes32 internal constant SENT_MESSAGE_EVENT_SELECTOR = | |||
There was a problem hiding this comment.
Can we use the selector property on the event itself rather than hardcoding it and needing it to change?
tynes
reviewed
May 12, 2025
| @@ -145,19 +146,22 @@ contract L2ToL2CrossDomainMessenger is ISemver, TransientReentrancyAware { | |||
| if (_target == Predeploys.L2_TO_L2_CROSS_DOMAIN_MESSENGER) revert MessageTargetL2ToL2CrossDomainMessenger(); | |||
|
|
|||
| uint256 nonce = messageNonce(); | |||
| bytes memory context = ""; | |||
There was a problem hiding this comment.
I am confused, should there be a sendMessage(uint,address,bytes,bytes) in addition where the context can be set?
|
Can you link the specs PR to this PR? edit: I see ethereum-optimism/specs#700 |
opgitgovernance
added
the
S-stale
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
hamdiallam
changed the title
|
Closing in favor of #16150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Design Doc.