-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[backports] op-deployer: Support custom OPCM #16546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raffaele-oplabs
merged 5 commits into
backports/op-deployer/v0.3.0
from
ss/backport-deployer-custom-opcm
Jun 26, 2025
Merged
[backports] op-deployer: Support custom OPCM #16546
raffaele-oplabs
merged 5 commits into
backports/op-deployer/v0.3.0
from
ss/backport-deployer-custom-opcm
Jun 26, 2025
+426
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* op-deployer: Fix intent validation with pre-deployed OPCM Previously, users were always required to provide the `SuperchainRoles` in their intent. Now that the intent supports providing an OPCM address, this is no longer necessary since we can look those values up on chain. The lookup was implemented in #15623, however users still had to provide `SuperchainRoles` in their intent to avoid validation errors. The new logic is as follows: - `standard` intents **must** specify the correct, standard OPCM address for the specified L1 and contracts version. Anything else is an error. - All other intent types must **either** specify `SuperchainRoles`, or an OPCM address. Specifying both or neither will result in an error. - The deployment pipeline will always pull `SuperchainRoles` data from the chain if the OPCM address is specified. Previously, it would only do this if the OPCM address was specified _and_ the L1 locator was a tag. * cr updates
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## backports/op-deployer/v0.3.0 #16546 +/- ##
================================================================
- Coverage 46.13% 41.77% -4.36%
================================================================
Files 1046 876 -170
Lines 90600 80668 -9932
================================================================
- Hits 41795 33702 -8093
+ Misses 45706 44038 -1668
+ Partials 3099 2928 -171
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mslipper
reviewed
Jun 24, 2025
packages/contracts-bedrock/scripts/deploy/ReadSuperchainDeployment.s.sol
Outdated
Show resolved
Hide resolved
mslipper
approved these changes
Jun 26, 2025
fed79f5
into
backports/op-deployer/v0.3.0
51 checks passed
bitwiseguy
added a commit
that referenced
this pull request
Jun 27, 2025
* op-deployer: Support custom OPCM (#15623) * op-deployer: use w3 instead of ReadSuperchainDeployment script * op-deployer: Fix intent validation with pre-deployed OPCM (#15712) * op-deployer: Fix intent validation with pre-deployed OPCM Previously, users were always required to provide the `SuperchainRoles` in their intent. Now that the intent supports providing an OPCM address, this is no longer necessary since we can look those values up on chain. The lookup was implemented in #15623, however users still had to provide `SuperchainRoles` in their intent to avoid validation errors. The new logic is as follows: - `standard` intents **must** specify the correct, standard OPCM address for the specified L1 and contracts version. Anything else is an error. - All other intent types must **either** specify `SuperchainRoles`, or an OPCM address. Specifying both or neither will result in an error. - The deployment pipeline will always pull `SuperchainRoles` data from the chain if the OPCM address is specified. Previously, it would only do this if the OPCM address was specified _and_ the L1 locator was a tag. * cr updates * op-deployer: fix OPCMImplAddressFor * remove unused ReadSuperchainDeployment.s.sol script --------- Co-authored-by: Matthew Slipper <[email protected]>
bitwiseguy
added a commit
that referenced
this pull request
Jun 27, 2025
* op-deployer: Support custom OPCM (#15623) * op-deployer: use w3 instead of ReadSuperchainDeployment script * op-deployer: Fix intent validation with pre-deployed OPCM (#15712) * op-deployer: Fix intent validation with pre-deployed OPCM Previously, users were always required to provide the `SuperchainRoles` in their intent. Now that the intent supports providing an OPCM address, this is no longer necessary since we can look those values up on chain. The lookup was implemented in #15623, however users still had to provide `SuperchainRoles` in their intent to avoid validation errors. The new logic is as follows: - `standard` intents **must** specify the correct, standard OPCM address for the specified L1 and contracts version. Anything else is an error. - All other intent types must **either** specify `SuperchainRoles`, or an OPCM address. Specifying both or neither will result in an error. - The deployment pipeline will always pull `SuperchainRoles` data from the chain if the OPCM address is specified. Previously, it would only do this if the OPCM address was specified _and_ the L1 locator was a tag. * cr updates * op-deployer: fix OPCMImplAddressFor * remove unused ReadSuperchainDeployment.s.sol script --------- Co-authored-by: Matthew Slipper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #16430. Since the
ReadSuperchainDeployments.s.sol
script doesn't exist in theop-contracts/v3.0.0
artifacts, those rpc calls are reimplemented in go (using w3) instead of using the script.Tests
Manually tested deploying a new op chain using the following sequence: