Skip to content

op-supervisor,op-node: reset: Local unsafe target determination at supervisor #16557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

pcw109550
Copy link
Contributor

@pcw109550 pcw109550 commented Jun 24, 2025

Description

TODO

  • remove redundant op-node side localunsafe traversal + fix test
  • check what info does supervisor db holds, and if the info is reliable use it instead of op-node RPC call(by not adding interop_l2BlockRefByNumber

Tests

Additional context

Metadata

Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (d071966) to head (6e0fa59).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16557       +/-   ##
============================================
+ Coverage    82.12%   96.24%   +14.11%     
============================================
  Files          161      106       -55     
  Lines         9277     4584     -4693     
============================================
- Hits          7619     4412     -3207     
+ Misses        1499      172     -1327     
+ Partials       159        0      -159     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 96.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-supervisor: Improve reorg during reset behavior
1 participant