Skip to content

op-supervisor: add API for Failsafe mode (part of AutoStop) #16582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025

Conversation

axelKingsley
Copy link
Contributor

What

Implements basic API for AutoStop:

  • Get and Set Admin API
  • Held as a simple atomic.Bool
  • Whenever CheckAccessList is called, isAutoStop is checked and may short circuit the function to return ErrAutoStop
  • Flags and Config included to set auto-stop as enabled on startup (for safety during operations which may include a reboot of the supervisor)

ProxyD and Geth may both call the GetAutoStop API to control their own rejection logic. Meanwhile, operators and metrics can use SetAutoStop to control the behavior.

Still to come (after this PR):

  • Monitoring hooks for AutoStop
  • AutoStop enablement when a Block Invalidation happens

Testing

New unit tests confirming:

  • Use of the config for initial values
  • Functional Get/Set
  • Blocking of CheckAccessList only when enabled

@axelKingsley axelKingsley requested review from a team as code owners June 25, 2025 20:54
@axelKingsley axelKingsley requested a review from tynes June 25, 2025 20:54
@axelKingsley axelKingsley changed the title op-supervisor: Basic AutoStop API op-supervisor: AutoStop API Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (87d8c73) to head (fe13c77).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #16582       +/-   ##
============================================
- Coverage    81.96%        0   -81.97%     
============================================
  Files          161        0      -161     
  Lines         9304        0     -9304     
============================================
- Hits          7626        0     -7626     
+ Misses        1519        0     -1519     
+ Partials       159        0      -159     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 161 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoknee geoknee changed the title op-supervisor: AutoStop API op-supervisor: FailsafeMode API (part of AutoStop) Jun 26, 2025
@geoknee geoknee changed the title op-supervisor: FailsafeMode API (part of AutoStop) op-supervisor: add API for Failsafe mode (part of AutoStop) Jun 26, 2025
@axelKingsley axelKingsley added this pull request to the merge queue Jun 26, 2025
Merged via the queue into develop with commit c2f9bb1 Jun 26, 2025
61 checks passed
@axelKingsley axelKingsley deleted the supervisor-autostop-api branch June 26, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants