-
Notifications
You must be signed in to change notification settings - Fork 3.6k
op-supervisor: add API for Failsafe mode (part of AutoStop) #16582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+181
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16582 +/- ##
============================================
- Coverage 81.96% 0 -81.97%
============================================
Files 161 0 -161
Lines 9304 0 -9304
============================================
- Hits 7626 0 -7626
+ Misses 1519 0 -1519
+ Partials 159 0 -159
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
geoknee
reviewed
Jun 26, 2025
geoknee
approved these changes
Jun 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements basic API for AutoStop:
atomic.Bool
CheckAccessList
is called,isAutoStop
is checked and may short circuit the function to returnErrAutoStop
ProxyD and Geth may both call the
GetAutoStop
API to control their own rejection logic. Meanwhile, operators and metrics can useSetAutoStop
to control the behavior.Still to come (after this PR):
Testing
New unit tests confirming:
CheckAccessList
only when enabled