Skip to content

Conversation

radik878
Copy link

@radik878 radik878 commented Oct 6, 2025

  • Problem: The error handling after parsing the initial-bond flag was inverted. On successful parse, the code returned an error; on parse failure, it assigned the (nil/invalid) value. This caused valid inputs to be rejected and invalid inputs to proceed until failing later in config validation.
  • Why fix: The bug breaks normal CLI usage, makes error messages misleading, and can lead to confusing runtime failures. Correct handling ensures valid bonds are accepted, invalid inputs are rejected early with a clear error, and downstream checks behave as intended.

@radik878 radik878 requested a review from a team as a code owner October 6, 2025 10:07
@radik878 radik878 requested a review from pauldowman October 6, 2025 10:07
@Inphi
Copy link
Contributor

Inphi commented Oct 7, 2025

/ci authorize ff5fc56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants