Skip to content

eth: improve filter API spec #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

eth: improve filter API spec #633

merged 1 commit into from
Aug 25, 2025

Conversation

prestwich
Copy link
Contributor

@prestwich prestwich commented Feb 27, 2025 •
edited
Loading

  • Filters do not register for notifications
  • filter IDs are required for many methods
  • the log filter object is required for the newFilter method
  • getFilterChanges returns an array of things depending on the filter

I do not know what getFilterLogs does, but the spec is identical to filter changes, so i suspect either

  • the spec is in error here and it returns only logs
  • the description is in error, and the name is misleading, and it may return block or tx hashes

@prestwich
correct filter api spec
62bda45 
- Filters do not register for notifications
- filter IDs are required for many methods
- the log filter object is required for the newFilter method
@fjl fjl changed the title correct filter api spec eth: improve filter API spec Aug 25, 2025
@fjl fjl merged commit 3c429f5 into ethereum:main Aug 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @fjl