-
Notifications
You must be signed in to change notification settings - Fork 162
chore(tests|forks): add max blobs per tx limit #1884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tried to fix the coverage for this line below, in the following commit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing obvious stands out to me here! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple of comments, thanks!
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py
Outdated
Show resolved
Hide resolved
3571174
to
193ea5e
Compare
cf09141
to
7e0c5c7
Compare
Just commenting on the fixture diffs for the changes to the 4844 tests - Cancun/Prague:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments which I feel would bring down the number of lines changed and also simplify code readabilit IMO, unless I'm missing something.
tests/cancun/eip4844_blobs/test_excess_blob_gas_fork_transition.py
Outdated
Show resolved
Hide resolved
6287172
to
e03bfcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for the refactor I think changes look much simpler now.
Thanks!
57b729e
to
6018bb9
Compare
51cb578
to
97399d4
Compare
🗒️ Description
Following the changes to EIP-7594: ethereum/EIPs#9981
Adds some more
execute_blobs
tests for PeerDAS, including tests for the new max blobs per tx limit.Updates fork logic and EIP-4844 tests to use a new
max_blobs_per_tx
function.Adds specific tests for the new change (including transition tests) within the PeerDAS EIP testing folder.
Fill with the latest EELS
forks/osaka
.Requires
🔗 Related Issues or PRs
#1798
Requires: #1784
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.