[FEATURE] Added Core modifier "hook" #412
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the server registry is not loaded
…just diff to what I expected
|
I actually now think that it should not be an expected fail... the "modifiers" implies there is a default that we overwrite. But here, we actually SET env vars dict. I will come back to this later today. I'll likely not be able to continue the topic today. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is my first true feature that I add here and want to pick your brain here.
Entire PR is related to this issue.
So I developed some code to allow the feature, added example and tests.
But the tests are not passing because I assumed the 'env' part of the server registry is set. Meanwhile it is
Noneand I dunno how to set it. I thought that it is initialized at the same moment asCorebut clearly not. How would you test the intended behaviour? I run the example and agent correctly starts the servers with provided envs.For now I just marked the tests that do not work as I expected them to to 'xfail' because I wanted to both leave them and have passing test suite - application is not broken, only the tests cannot show expected behaviour.