Explicit DemoMode, implemented through an extra state in auth object

[guido4096]

fixes #18946

[sourcery-ai]

Hey @guido4096 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[naltatis]

@guido4096 magst du mal make lint und make lint-ui drüber laufen lassen?

Am Besten aktivierst du in deinem Editor auch "format on save" für "prettier" und "go", dann gibts diese Art von Fehlern erst gar nicht 😀

[guido4096]

Maybe a highlight about the changes:

1. demo mode is activated using --demo
2. this is implemented using a new state in the auth object. The auth object now has states "enabled", "disabled" and "demomode". Enabled and Disabled work as before. The state demomode makes sure that login is not possible and that all actions that requires a logged in users are denied server side.
3. the state of "demomode" is then also communicated to the frontend through the regular auth api
   So for on my side this works quite nicely.

[guido4096]

One special thing; the auth state is done through an enum, making use of constants. These constants have to be referenced using something like "auth.Disabled" . In most of the functions, the auth object is passed through the variable name "auth" and this hides the constants. So I had find a new name for this variable and used "authObject" .

[guido4096]

Documentation needs to be still adapted, but I think better to first get the code and behavior reviewed and correct before doing doc changes.