Improved test for roll_the_die #2442
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
| Assert.InRange(strength, 0.0, 100.0); | ||
| } | ||
|
|
||
| Assert.True(rolls.Count >= minUniqueValues, |
There was a problem hiding this comment.
Could you use Assert.InRange here? That would give nice error messages and you don't have to use the custom assert message
There was a problem hiding this comment.
@ErikSchierboom Done, kindly review the PR, thanks.
- Tests now check whether multiple rolls supply different results
- RollDie is checked for returning all values in the expected range
- Increased for loop from 100 times to 1000 times to prevent false negative. Encountered that 100 rolls was not sufficient to have all numbers in range(1, 18) to be generated.
Rationale:
My first implementation (thanks XKCD) made the test suite pass.
```
public int RollDie()
{
return 4; // chosen by fair dice roll.
// guaranteed to be random.
}
```
KaranChadha10
force-pushed
the
nash-roll-the-die
branch
from
74e8ea4 to
16acce9
Compare
2 participants
Tests now check whether multiple rolls supply different results