add error-handling exercise #2732
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
| console.log = jest.fn(); | ||
|
|
||
| try { | ||
| processString(''); | ||
| } catch { | ||
| /* | ||
| intentionally left empty, | ||
| I expext this call to throw, | ||
| but only care about verifying that the finally block is executed | ||
| and clean up message logged. | ||
| */ | ||
| } | ||
|
|
||
| expect(console.log).toHaveBeenCalledWith('Resource cleaned up'); |
There was a problem hiding this comment.
I don't think this will work with the Browser Test Runner, but the idea is not wrong. I can help come up with an easy alternative to fix this.
…m/A-O-Emmanuel/javascript into implement-error-handling-exercise
| expect(() => processString('')).toThrow('EmptyStringError'); | ||
| }); | ||
|
|
||
| it('always logs cleanup message', () => { |
There was a problem hiding this comment.
This test checks if a cleanup message is logged after an empty string is provided. That isn’t the same as checking if a cleanup message is always logged.
| @@ -0,0 +1,7 @@ | |||
| export const processString = (input) => { | |||
| //TODO: implement this | |||
| //should throw Error if input is not a string | |||
There was a problem hiding this comment.
This line isn’t correct. The test suite is looking for a specific error type.
| export const processString = (input) => { | ||
| //TODO: implement this | ||
| //should throw Error if input is not a string | ||
| //should throw Error if input is an empty string |
There was a problem hiding this comment.
This implies any Error can be thrown with any message, but that’s not true.
| //TODO: implement this | ||
| //should throw Error if input is not a string | ||
| //should throw Error if input is an empty string | ||
| //should return the uppercase version of the string if valid |
There was a problem hiding this comment.
What’s considered valid here? This line implies by nearness that not all strings are valid, but it’s not clear what is valid.
| //should throw Error if input is not a string | ||
| //should throw Error if input is an empty string | ||
| //should return the uppercase version of the string if valid | ||
| //should use finally to log cleanup message |
…r-handling.spec.js
Implemented the Error Handling practice exercise with solution, tests, and documentation