BookingId mandatory for Messages #50
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing the full API booking flow, we found out hard and counter-intuitive to leave open the sending of messages WITHOUT a Booking context.
As a consequence, we propose to :
bookingIdrequired inPOST /messages) ;messageoptional attribute added inPOST /bookingsas it is already available in thePATCH /bookingsendpoint) ;INITIATEDbookingStatus (thisbookingStatusis just used in the full API booking flow) to differenciate booking started just a casual chat and a formal booking request made by the passenger to the driver.