Skip to content

Conversation

stevenwilliamson
Copy link

@stevenwilliamson stevenwilliamson commented Mar 21, 2025

  • Updates dependencies, i think all are development deps as the only non dev dep declared in the spec is mysql2
  • Update docker image to debian as alpine failing
  • Update to mysql8 for test image

All tests pass, however coverage appears down by a minor %, it's complaining that a single line in the spec file is not covered by tests which i don't fully understand

➜  mysql2-aurora git:(update_deps) ✗ docker-compose run --rm app ./bin/test
WARN[0000] /Users/steve/dev/mysql2-aurora/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion 
[+] Creating 1/1
 ✔ Container mysql2-aurora-mysql-1  Running                                                                                                                                              0.0s 
fatal: detected dubious ownership in repository at '/app'
To add an exception for this directory, call:

	git config --global --add safe.directory /app

Randomized with seed 22434

Mysql2::Aurora::Client
  connection flags
    supports multi statements after reconnect
  #method_missing
    Delegate to #client
  .const_missing
    Delegate to Mysql2::Client
  Mysql2::Aurora::VERSION
0.5.6
    Valid version
  .method_missing
    Delegate to Mysql2::Client
  #client
    Return original Mysql2::Client instance
    Return correctly client
  Mysql2::Client
    Return Mysql2::Aurora::Client
  #query
    Return result
    Call original query
    When aurora_disconnect_on_readonly is true
      #query
        disconnects immediately
    When raise Mysql2::Error
      Retry interval is valid
      Retry query
      Mysql2::Error is not failover error
        Not retry query
    When StandardError
      Not retry query
  #reconnect!
    Close old #client
    Set new Mysql2::Client to #client
    When #close raise error
      Not raise error
      Set new Mysql2::Client to #client
    When #query_options is changed
      #query_options are inherited
    When `client` is nil
      Set new Mysql2::Client to #client

Finished in 0.05927 seconds (files took 0.28795 seconds to load)
21 examples, 0 failures

Randomized with seed 22434

Coverage report generated for RSpec to /app/coverage. 167 / 168 LOC (99.4%) covered.
[Coveralls] Outside the CI environment, not sending data.

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Converage is under 100%. See `coverage/index.html`
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Updates dependencies, i _think_ all are development deps as the only non
dev dep declared in the spec is mysql2
alpine seemed to be having trouble accessing the repos with various SSL
errors. We deploy to debian based images and they are popular elsewhere
to move to this for the testing image
The test for checking the version was failing, possibly related to the
ruby upgrade, but to avoid future issues relax to the check to simple
make sure the version is of the format x.x.x
Also add gems to gemspec that are no longer bundled by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant