-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/telemetry #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacobbamio
wants to merge
7
commits into
main
Choose a base branch
from
fix/telemetry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/telemetry #13
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
98e48f9
updated docs to match defaults
jacobbamio 23a24ee
added mapping keys to match idiomatic enabled and keep compatibility …
jacobbamio 9ffd508
changed into enabled to be idiomatic
jacobbamio d5d6acd
match enabled
jacobbamio 2beb6fd
match enabled + api compatibility test
jacobbamio c4bcecb
added contexts
jacobbamio a8bd893
updated cassettes
jacobbamio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 11 additions & 11 deletions
22
spec/fixtures/vcr_cassettes/mastra_generate_agent_object.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in order to be more idiomatic for ruby, while using the required Mastra API prop. I explored putting it directly in the camelized options with an if clause, but if in the future we adapt other API methods that are not idiomatic for Ruby, this way we just add it to the hash.
I'm changing this because before we had the is_enabled, which was the Mastra prop name, but you told me to use enabled to be more idiomatic ( which I think is a good tip tbh ).
Any other approach you think would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry. What I mean is that this feels very complex just for one particular case. When you pass the telemetry settings to the options, couldn't the settings itself know how to serialize themselves (so returning a hash with is_enabled) instead of having the client know about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes hella more sense, yup, ty