🐛 Fix TypeError for fields annotated with Literal
#1439
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsaccente
changed the title
|
I have no idea how to add the proper labels to this PR, it looks like the permissions aren't set up to allow me to. |
YuriiMotov
changed the title
TypeError for fields annotated with Literal
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
8 tasks
|
@nsaccente, thanks for working on this! |
Sure. I'll try to get that done sometime this week. |
…del into bugfix-57/literal-satype
nsaccente
force-pushed
the
bugfix-57/literal-satype
branch
from
2aaef2d to
3c024e2
Compare
|
I've been fighting with getting the tests to work. I've been able to get things to pass in some versions of python, but not others. Any guidance on how to run these CI tests locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue 57. The original issue explains that attempting to use a Literal type annotation in a SQLModel raises a type error from
issubclass. This is becauseLiteralis not a class, but a typing._SpecialForm, so static funcs likeisinstanceandissubclassdon't work with it.The fix was pretty straightforward, I just added a check before an
isinstanceorissubclasswould have been called that checksif type_ is Literal.