Add basic Calendar support/tests to JMAP::TestSuite #27
Conversation
|
@rsto Only "are any of the properties we're creating, or values we're putting in them, not actual specified properties". In the past, we've done stuff (by accident) like test for Cyrus-only properties, or dead properties that Cyrus ignored. |
There was a problem hiding this comment.
This looks to be based on a fairly old spec. The most recent definition of the Calendar type is at https://www.ietf.org/archive/id/draft-ietf-jmap-calendars-22.html#section-4
| color => jstr, | ||
| sortOrder => jnum, | ||
| isVisible => jbool, | ||
| mayReadFreeBusy => jbool, |
There was a problem hiding this comment.
The mayXxx items aren't top-level properties in the Calendar object type. Instead, the top-level property is myRights. Also, these rights look outdated, e.g. the mayRVSP or the mayUpdatePrivate right is missing.
See the definition of the CalendarRights object type in https://www.ietf.org/archive/id/draft-ietf-jmap-calendars-22.html#section-4
| my %required = ( | ||
| id => jstr, | ||
| name => jstr, | ||
| color => jstr, |
| name => jstr, | ||
| color => jstr, | ||
| sortOrder => jnum, | ||
| isVisible => jbool, |
There was a problem hiding this comment.
The following non-null, non-default properties are missing:
- isSubscribed
- isDefault
- includeInAvailability
| id => jstr, | ||
| name => jstr, | ||
| color => jstr, | ||
| sortOrder => jnum, |
There was a problem hiding this comment.
sortOrder isn't strictly required, it has a default value (0).
| use Carp (); | ||
| with 'JMAP::TestSuite::Entity' => { | ||
| singular_noun => 'calendar', | ||
| properties => [ qw( |
There was a problem hiding this comment.
Same as in Comparator/Calendar.pm.
No description provided.