Add a semicolon at the end of min.bean.js #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the makefile. It appends as semicolon to the minified version of Bean. This fixes errors when concatinating files in a single script on deploy.
| @@ -101,13 +101,13 @@ | |||
| // a whitelist of properties (for different event types) tells us what to check for and copy | |||
| var commonProps = str2arr('altKey attrChange attrName bubbles cancelable ctrlKey currentTarget ' + | |||
| 'detail eventPhase getModifierState isTrusted metaKey relatedNode relatedTarget shiftKey ' + | |||
| 'srcElement target timeStamp type view which propertyName') | |||
| 'srcElement target timeStamp type view which propertyName path') | |||
There was a problem hiding this comment.
did you add these properties?
There was a problem hiding this comment.
No.
Those where added in a previous PR #116. I just made a new build. As those new properties where added in the source but where not yet compiled to the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #117