-
Notifications
You must be signed in to change notification settings - Fork 11
Discover plugins automatically #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Otherwise it messes with the bundler and lets `vitest` seep into the non-Vitest bundle
🦋 Changeset detectedLatest commit: f61536f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR decouples the steiger package from the @feature-sliced/steiger-plugin dependency while retaining zero-config operation, and improves testing support by updating import paths to use the new @steiger/toolkit/test entrypoint. It also introduces new integration tests and utility functions to further validate plugin discovery and overall functionality.
- Updated import paths in test files across the steiger-plugin-fsd package.
- Added integration test utilities (e.g., get-snapshot-path, get-repo-root-path) and tests for plugin discovery.
- Updated snapshots and package dependencies in pretty-reporter and examples to reflect the decoupled architecture.
Reviewed Changes
Copilot reviewed 71 out of 71 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
packages/steiger-plugin-fsd/* | Updated test imports to refer to the new test entrypoint from @steiger/toolkit/test. |
packages/pretty-reporter/package.json | Added vitest dependency to support updated testing. |
integration-tests/utils/* | New utility functions to support integration tests. |
integration-tests/tests/* | New integration tests for auto plugin discovery and updated snapshot validations. |
.changeset/curly-years-sparkle.md | Changeset documenting the vitest-related refactoring. |
Comments suppressed due to low confidence (1)
integration-tests/tests/discover-plugins.test.ts:138
- [nitpick] Consider renaming the parameter 'process' to 'childProcess' to avoid potential confusion with the Node.js global process object.
function getNewProcessOutput(process: ChildProcess, { until, stream = 'stdout' }: { until?: string; stream?: 'stdout' | 'stderr' } = {}): Promise<string> {
This PR marks an important internal architectural milestone — decoupling the
steiger
package from the@feature-sliced/steiger-plugin
dependency while still retaining zero-config operation.