Skip to content

Conversation

@PayalKhanna
Copy link
Contributor

update expectations for #4048

@PayalKhanna PayalKhanna requested a review from a team as a code owner October 14, 2025 15:02
@netlify
Copy link

netlify bot commented Oct 14, 2025

Deploy Preview for finos-cdm ready!

Name Link
🔨 Latest commit 97628f9
🔍 Latest deploy log https://app.netlify.com/projects/finos-cdm/deploys/68ee69ce69fc020008c1a94e
😎 Deploy Preview https://deploy-preview-4107--finos-cdm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

},
"threshold" : {
"partyElection" : [ {
"party" : "Party1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayasriR Party1 has gone missing here

}
}
}, {
"party" : "Party2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Party2 is missing here.

"baseCurrency" : "GBP"
},
"creditSupportObligations" : {
"threshold" : {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threshold has gone missing in this sample.

},
"threshold" : {
"partyElection" : [ {
"party" : "Party1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Party1 is missing here.

}
}, {
"party" : "Party2",
"customElection" : "10 tons of Gold"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming with @Siddharth-Yagnamurthy

Should this be mapped to ThresholdElection -> Other?

},
"threshold" : {
"partyElection" : [ {
"party" : "Party1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Party's are missing here.

"baseCurrency" : "EUR"
},
"creditSupportObligations" : {
"threshold" : {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threshold missing here.

},
"creditSupportObligations" : {
"threshold" : {
"partyElection" : [ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threshold party election values gone missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants