Skip to content

feat: Implement Twitter provider #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: development
Choose a base branch
from
Open

feat: Implement Twitter provider #1276

wants to merge 17 commits into from

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 10, 2025 •
edited
Loading

  • implement protocol AuthProviderUI for Twitter for rendering button
  • implement protocol AuthProviderSwift for Twitter for signing in via Twitter.
  • Update withTwitterSignIn() to accept provider.
  • update deleter user logic.
  • Update button styling to closer to Twitter.
  • Need to update naming in AccountService+Twitter to use Twitter.
  • Write tests to show its appearance in the UI (could do this for all providers).

@russellwheatley
feat: Implement Twitter provider
92e1453
@russellwheatley
fix: twitter provider update to be pass through withTwitterSignIn()
819e05b
@russellwheatley
fix: import twitter to allow sign-in
c233113
@russellwheatley
refactor: provider logic so it can be passed into button
ef5f786
@russellwheatley
fix: display name if email is unavailable, twitter sometimes user use…
ad137a0 
…rname instead of email
@russellwheatley
chore: use withTwitterSignIn() for test and content view
4cb5f27
@russellwheatley
feat: pass provider to providerWithUI
76e8ceb
@russellwheatley
fix: renamed arg to make it clear the distinction between provider & …
5283f65 
…provider + button
@russellwheatley
fix: make provider arg optional
4dbd565
@russellwheatley
feat: implement API for deleting Twitter user
1b6a295
@russellwheatley
fix: put delete function on the provider
7a37a33
@russellwheatley
format
ac7f146
@russellwheatley
feat: Twitter sign-in button styling
94415ff
@russellwheatley
chore: change button name to "X"
cab823c
@russellwheatley
test: sign in buttons are visible on auth picker
854a506
@russellwheatley
fix: sometimes email isn't available so use as: instead
d1602f8
@russellwheatley
fix: remove incorrect naming
4897996
@russellwheatley russellwheatley marked this pull request as ready for review October 10, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@russellwheatley