Skip to content

fix(firebaseai): Added token details parsing for Dev API #17609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Aug 7, 2025

Added parsing for promptTokensDetails and candidatesTokensDetails when using the Gemini Developer API (Google AI). This PR updates developer/api.dart (Google AI) to use parseUsageMetadata from api.dart (Vertex AI) since the implementations should be identical.

Note: This is a follow-up to #17608.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos analyze-ci) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

google-labs-jules bot and others added 4 commits August 7, 2025 20:11
- Added `thoughtsTokenCount` to `_parseUsageMetadata` in `packages/firebase_ai/firebase_ai/lib/src/api.dart` to align with the implementation in the developer API.
- Added unit tests for `thoughtsTokenCount` parsing in `packages/firebase_ai/firebase_ai/test/api_test.dart`.
@andrewheard andrewheard added the plugin: ai label issues for firebase_ai plugin label Aug 7, 2025
@andrewheard andrewheard marked this pull request as ready for review August 7, 2025 22:14
@andrewheard andrewheard force-pushed the feat-parse-usage-metadata-details branch from 258612b to 917f432 Compare August 7, 2025 22:43
@andrewheard andrewheard changed the base branch from main to ah/add-thoughts-token-count August 7, 2025 22:44
Base automatically changed from ah/add-thoughts-token-count to main August 8, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: ai label issues for firebase_ai plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants