snapshots: fix archive #5696
Open
snapshots: fix archive #5696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-fix-1
branch
from
61f53b2 to
24ed764
Compare
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-fix-1
branch
from
24ed764 to
d24686b
Compare
cali-jumptrading
force-pushed
the
cali/snapshot-tiles-fix-1
branch
from
d24686b to
abc6cc3
Compare
mmcgee-jump
reviewed
Jul 16, 2025
| @@ -0,0 +1,56 @@ | |||
| #ifndef HEADER_fd_src_discof_restore_utils_fd_snapshot_archive_h | |||
There was a problem hiding this comment.
Really prefer the old filename, more consistent with fd style. E.g. see fd_tpool, not fd_thread_pool, and many other cases.
There was a problem hiding this comment.
Keystrokes are cheap. Nobody but the original maintainers would know what an ssarchive is looking at a directory listing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.