Skip to content

fix: include LabelValue in the default bundle (sync) #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

fix: include LabelValue in the default bundle (sync) #4235

wants to merge 1 commit into from

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Aug 22, 2025 •
edited
Loading

Fixes #4219

Changes proposed in this pull request:

  • Makes the LabelValue component always available to import in sync mode.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@SychO9 SychO9 requested a review from a team as a code owner August 22, 2025 11:12
@luceos luceos self-requested a review August 23, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos Awaiting requested review from luceos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.x] Make sure all common JS components, etc... are accessible
1 participant
@SychO9