Skip to content

Conversation

johannsa
Copy link
Contributor

@johannsa johannsa commented Sep 27, 2025

Fixes #4240

Changes proposed in this pull request:
Added support for specifying and using pgsql's search_path

Reviewers should focus on:

  • Some changes to existing classes and method signatures.
  • Some changes to UI:
    • Addition of a "Schema" field.
    • Triggering the update of the UI upon DOM loading, so that the field is only displayed for the relevant driver.

Screenshot

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
    • Not acceptable: Install in "public" schema, then move tables to other schema and finally change config.php.
  • For core PRs, does this need to be in core, or could it be in an extension?
    • Needs to be in core as the issue/limitation exists since install.
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
    • There is no such command on my composer.jsons
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@johannsa johannsa requested a review from a team as a code owner September 27, 2025 22:07
@johannsa
Copy link
Contributor Author

johannsa commented Sep 27, 2025

I am working on those failed test ✅ Done!

@johannsa johannsa changed the title Added support for pgsql's search_path feat: Added support for pgsql's search_path Oct 3, 2025
@johannsa johannsa changed the title feat: Added support for pgsql's search_path feat: Add support for pgsql's search_path Oct 3, 2025
@imorland imorland added this to the 2.0.0-beta.4 milestone Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.x] Add support for pgsql's search_path

2 participants