feat: add privileged flag, allow adding absolute path for volume #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
reviewed
Jul 24, 2025
| // WithAbsoluteVolume adds a volume mapping using an absolute path on the host. | ||
| // This is useful for binding system paths like /var/run/docker.sock. | ||
| // The path must be absolute and will be used as-is without any modification. | ||
| func (s *Service) WithAbsoluteVolume(containerPath string, hostPath string) *Service { |
There was a problem hiding this comment.
We used it in our own components in our fork, especially for the case when binding paths which are not in the project path ~/.playground/devnet (like i.e. /var/run/docker.sock).
It is not being used in the standard builder-playground but we thought it might be useful to have it there for projects which fork the builder-playground and add their own components to it, like we did.
But I also understand if it's not desired to keep it upstream. Feel free to either close or approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the privileged flag to be set for services. Additionally, we added a way to mount absolute paths from the filesystem to any service, which is useful if you want to bind
/var/run/docker.sockNote
At phylax systems, we used the builder-playground to generate our demo environment for OP-Talos.
During our work we made a small set of changes which are worth suggesting as upstream contributions.
I tried to split the work in several PRs, to let the maintainers decide what is worth to be included.