Uses complex dtypes in cufinufft py tests #705
Conversation
janden
force-pushed
the
cufinufft_test_dtypes
branch
from
bbd0bce to
dd50854
Compare
There was a problem hiding this comment.
It seems jenkins failed on the newly merged test_cufinufft3_simple test https://jenkins.flatironinstitute.org/blue/organizations/jenkins/finufft/detail/PR-705/4/pipeline
I guess we need to merge master to this branch do the change for test_cufinufft3_simple too.
And real_dtype seems not used anywhere.
There was a problem hiding this comment.
I guess we need to merge master to this branch do the change for
test_cufinufft3_simpletoo.
Ok I rebaed on top of master and made the changes. Let's see how the tests do.
And
real_dtypeseems not used anywhere.
I don't quite understand. It's used to generate the correct dtypes for the frequencies, no? See here:
finufft/python/cufinufft/tests/utils.py
Line 52 in c9e6a27
There was a problem hiding this comment.
Great! Thanks, all the jenkins tests pass. I think it's good to merge.
I just happen to see the two variables real_dtype defined in file test_simple.py are not used.
There was a problem hiding this comment.
Ah I see. I've removed them now. Thanks!
Will wait for tests to finish and then merge.
janden
force-pushed
the
cufinufft_test_dtypes
branch
from
ccba36c to
c9e6a27
Compare
There was a problem hiding this comment.
Great! Thanks, all the jenkins tests pass. I think it's good to merge.
I just happen to see the two variables real_dtype defined in file test_simple.py are not used.
Fixes #413.