-
Notifications
You must be signed in to change notification settings - Fork 6
Fixing wrong derivative bug and GPU bug #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
From the other open pull request it is clear the developers are aware, but recall that you need to top pin jax <= 0.6.2 . |
Hi please see #160 as I believe it resolves the issue, which stems from |
for more information, see https://pre-commit.ci
@TomHilder Glad you found it as well! They should buy us a smoothie or something. I am still getting some issues, I'll share if there's some direction to debug if you are working on this also |
@dfm @TomHilder @lgarrison Any ideas on the GPU bug? Don't be fooled by the close tolerance on some of the tests. There are others where the difference is large enough that is cannot be due to floating point errors. |
Once I mark this ready, I can squash merge.
main
, all the tests do is check whether thenufft
can do function approximation on uniformly random noise with zero mean. There's basically one free parameter in those tests, so errors are less likely to be detected. At a cursory glance, due to linearity, those tests inmain
may pass more often than they should.modeord
bug that yields incorrect derivatives