Skip to content

Fixing wrong derivative bug and GPU bug #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

unalmis
Copy link

@unalmis unalmis commented Aug 20, 2025

Once I mark this ready, I can squash merge.

@unalmis
Copy link
Author

unalmis commented Aug 20, 2025

From the other open pull request it is clear the developers are aware, but recall that you need to top pin jax <= 0.6.2 .

@unalmis unalmis changed the title Debugging derivatives Fixing derivatives Aug 20, 2025
@TomHilder
Copy link

Hi please see #160 as I believe it resolves the issue, which stems from jvp having a hard-coded assumption of the default mode ordering (modeord=0), which you aren't using here. Thanks!

@unalmis
Copy link
Author

unalmis commented Aug 20, 2025

@TomHilder Glad you found it as well! They should buy us a smoothie or something. I am still getting some issues, I'll share if there's some direction to debug if you are working on this also

@unalmis
Copy link
Author

unalmis commented Aug 20, 2025

@dfm @TomHilder @lgarrison Any ideas on the GPU bug? Don't be fooled by the close tolerance on some of the tests. There are others where the difference is large enough that is cannot be due to floating point errors.

@unalmis unalmis changed the title Fixing derivatives Fixing derivatives and bugs Aug 20, 2025
@unalmis unalmis changed the title Fixing derivatives and bugs Fixing wrong derivative bug and GPU bug Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting 64 bit floating point precision doesn't affect GPU computation [Bug] Results are wrong on GPU [Bug] Derivatives are wrong
2 participants