Skip to content

Refactor renderer to support vulkan extensions #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

xiaowei-guan
Copy link
Contributor

@xiaowei-guan xiaowei-guan commented Jun 27, 2025

#101
Main changes:

  • Make FlutterTizenView SetEngine and CreateRenderSurfcae methods private.
  • Add TizenRendererNui class to decorate GL renderer for NUI.
  • Remove GL renderer methods from FlutterTizenView.
  • Do not call CreateSurface and DestorySurface in FlutterTizenView.
  • Move GetRendererConfig to renderer.
  • Extract a new class for GL renderer.
  • Move create texture code from texture registrar to renderer.

Make SetEngine and CreateRenderSurfcae private.
1. Add TizenRendererNui class to decorate GL renderer.
1.Call CreateSurface when new renderer.
2.Call DestorySurface when desconstruct renderer.
@xiaowei-guan xiaowei-guan marked this pull request as draft June 27, 2025 08:59
@xiaowei-guan xiaowei-guan force-pushed the refactor-renderer-001 branch from 863bb70 to 908e900 Compare June 30, 2025 10:28
1.Fix texture registrar crash issue.
2.Temporary remove texture registrar unit test code, we need
re-implement this unit test code.
@JSUYA
Copy link
Member

JSUYA commented Jul 3, 2025

Hi about this commit 8121f5e ...
There was a similar case at #90.
Did you check window's code?

As the feature of tizen embedder has modified, there have been cases where we needed additional mock-up of the embedder api.
I haven't tested it yet, but if you look at flutter_windows_texture_registrar_unittests.cc in windows, you might need to add a mock-up of PostRenderThreadTask.
(flutter/engine/src/flutter/shell/platform/windows/flutter_windows_texture_registrar_unittests.cc)

@xiaowei-guan xiaowei-guan marked this pull request as ready for review July 4, 2025 01:42
@xiaowei-guan
Copy link
Contributor Author

Hi about this commit 8121f5e ... There was a similar case at #90. Did you check window's code?

As the feature of tizen embedder has modified, there have been cases where we needed additional mock-up of the embedder api. I haven't tested it yet, but if you look at flutter_windows_texture_registrar_unittests.cc in windows, you might need to add a mock-up of PostRenderThreadTask. (flutter/engine/src/flutter/shell/platform/windows/flutter_windows_texture_registrar_unittests.cc)

Fail to run texture unittest, because texture registrar fail to create ExternalTexture. Not related to Embedder API.
I added a macro definition for this unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants