[camera_android_camerax] Updates internal API wrapper to use ProxyApis #8618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Apr 10, 2025
...oid_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraAndroidCameraxPlugin.java
Outdated
Show resolved
Hide resolved
| public void onFailure(@NonNull Throwable t) { | ||
| ResultCompat.failure(t, callback); | ||
| } | ||
| }, |
There was a problem hiding this comment.
Optional: Is it worth making a helper factory for this void result compat shim? It looks like it's used in a fair number of places, so being able to replace this boilerplate with a new VoidResultCallback() or something along those lines might help readability.
There was a problem hiding this comment.
I guess the downside is that it would be less parallel with the ones that aren't just a trivial void callback passthrough.
There was a problem hiding this comment.
I attempted to make a subclass of FutureCallback<Void>, but got a RestrictedApi warning. I think it is expected to create the class inline as per the example: https://developer.android.com/develop/background-work/background-tasks/asynchronous/listenablefuture#getting_the_result_of_a_listenablefuture.
..._android_camerax/android/src/main/java/io/flutter/plugins/camerax/SystemServicesManager.java
Show resolved
Hide resolved
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2025
flutter/packages@f26b681...2fcc403 2025-04-15 [email protected] [camera_android_camerax] Updates internal API wrapper to use ProxyApis (flutter/packages#8618) 2025-04-14 [email protected] [tool] Run a config-only build before Xcode analyze (flutter/packages#9075) 2025-04-14 [email protected] [webview_flutter_android] Adds internal wrapper methods for native `WebViewClient`. (flutter/packages#8964) 2025-04-14 [email protected] [webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and updates native wrapper for `SecTrust` and `SecCertificate` (flutter/packages#9016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2025
flutter/packages@f26b681...2fcc403 2025-04-15 [email protected] [camera_android_camerax] Updates internal API wrapper to use ProxyApis (flutter/packages#8618) 2025-04-14 [email protected] [tool] Run a config-only build before Xcode analyze (flutter/packages#9075) 2025-04-14 [email protected] [webview_flutter_android] Adds internal wrapper methods for native `WebViewClient`. (flutter/packages#8964) 2025-04-14 [email protected] [webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and updates native wrapper for `SecTrust` and `SecCertificate` (flutter/packages#9016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Apr 16, 2025
…r#167218) flutter/packages@f26b681...2fcc403 2025-04-15 [email protected] [camera_android_camerax] Updates internal API wrapper to use ProxyApis (flutter/packages#8618) 2025-04-14 [email protected] [tool] Run a config-only build before Xcode analyze (flutter/packages#9075) 2025-04-14 [email protected] [webview_flutter_android] Adds internal wrapper methods for native `WebViewClient`. (flutter/packages#8964) 2025-04-14 [email protected] [webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and updates native wrapper for `SecTrust` and `SecCertificate` (flutter/packages#9016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ash2moon
pushed a commit
to ash2moon/flutter
that referenced
this pull request
Apr 21, 2025
…r#167218) flutter/packages@f26b681...2fcc403 2025-04-15 [email protected] [camera_android_camerax] Updates internal API wrapper to use ProxyApis (flutter/packages#8618) 2025-04-14 [email protected] [tool] Run a config-only build before Xcode analyze (flutter/packages#9075) 2025-04-14 [email protected] [webview_flutter_android] Adds internal wrapper methods for native `WebViewClient`. (flutter/packages#8964) 2025-04-14 [email protected] [webview_flutter_wkwebview] Fixes `loadFlutterAsset` exception and updates native wrapper for `SecTrust` and `SecCertificate` (flutter/packages#9016) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick-llewellyn
pushed a commit
to labrystechnology/flutter_packages
that referenced
this pull request
Apr 23, 2025
flutter#8618) Also Fixes flutter/flutter#164132 by passing a `TestInstanceManager` when needed.
10 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Fixes flutter/flutter#164132 by passing a
TestInstanceManagerwhen needed.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.