Bump create_all_packages_command CompileSdk to 36 #9293
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: is a test |
| @@ -19,7 +19,7 @@ pluginManagement { | |||
| // See https://github.com/flutter/flutter/blob/master/docs/ecosystem/Plugins-and-Packages-repository-structure.md#gradle-structure for more info. | |||
| plugins { | |||
| id "dev.flutter.flutter-plugin-loader" version "1.0.0" | |||
| id "com.android.application" version "7.0.0" apply false | |||
| id "com.android.application" version "8.1.0" apply false | |||
There was a problem hiding this comment.
Does this change correspond to a Flutter Fix or similar clear instruction from a build?
Also, has an AGP 7 test of any kind been added to flutter/flutter already? Traditionally this flutter/packages test is where we've found regressions in support for older AGP versions, so if we're going to bump this it would be good to backfill testing support in flutter/flutter. (It would be good anyway so we catch things earlier, but especially important if this last line of defense is going away.)
There was a problem hiding this comment.
I think there was a Flutter fix prompt/instructions to resolve the build issue, but there is no longer a need to update the AGP version of settings.gradle in legacy_project/all_packages. Merged the changes and resolved conflicts from the all_packages bump to 35 here, and the PR includes the AGP and Gradle bump needed. all_packages on SDK 36 now successfully builds.
flutter/packages@2bac766...ecba2db 2025-06-04 [email protected] Bump create_all_packages_command CompileSdk to 36 (flutter/packages#9293) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bumps the
create_all_packages_commandcompileSdkto 36. The test targets will test against the bump.Partially Adresses flutter/flutter#163071
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3