Skip to content

Conversation

LukasMirbt
Copy link
Contributor

@LukasMirbt LukasMirbt commented Sep 9, 2025

Fixes broken links in the Triage section of the readme.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version of go_router, adds a corresponding changelog entry, and fixes several links in the README.md file. The changes correctly update the issue tracker links to use the new p: go_router label. However, the link for package pull requests has been modified to exclude go_router_builder, which might be an oversight. My review includes a suggestion to re-include it to ensure the link is comprehensive.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai requested a review from justinmc September 9, 2025 17:22
@LukasMirbt LukasMirbt changed the title [go_router]: Fix broken links in readme [go_router] Fix broken links in readme Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants