Added read_variable_shaped to automate the read_variable reshaping chore #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That cellids parameter is a bit confusing, I would say. If it is -1, it reads the whole dataset and everything should go well. But If you only give it a limited subset, doesn't the argsort with the complete cellID dataset go belly-up? |
|
ooh, true. So I'll disable subset reading from that for now, so the functionality will at least exist for full datasets. |
| return np.squeeze(orderedData) | ||
|
|
||
|
|
||
| def read_variable_shaped(self, name, operator="pass"): |
There was a problem hiding this comment.
Please add variable name checking here so that if someone accidentally uses this for a fg_ variable, things won't break. Also, an AMR check would be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.