-
Notifications
You must be signed in to change notification settings - Fork 71
Wii: Scaling Fixes #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Wii: Scaling Fixes #130
Conversation
The keyboard's always been a bit odd with sizing. It's supposed to take an overall width and then automatically resize all the subkeys (example). If it's not working, there's probably an existing bug there. Long-term Chesto layout thoughts (putting in a collapsible)For the SCALER's, I'm also interested in a better way of accomplishing this. I think that ideally, any layout/positioning would mostly use Constraints and Containers, and not rely on hardcoded values. So, where there are SCALER's related to positioning, it would be better to position these in other ways. But in contrast, for scaling width and heights of elements (and including margin-ish gaps on containers/constraints), it'd be a lot better if there was just like a constant "scaling factor" that we could adjust at the base-level Element. Kind of like adjusting the zoom level in a browser. Then, even if they're hardcoded around a 720ish size, relative to each other they'd all be able to change size and automatically reposition themselves based on Constraints/Containers. That being said, in this PR there still aren't that many SCALERs (at least, not many more than already exist). And doing a larger refactor like that is not easily doable. Attaching photos of this branch built for PC with App List viewThe sidebar looks much better and actually fits on screen now! As does the positioning of the text and buttons along the top. Ideally, the AppCard dimensions being scaled down by a SCALER as well is all that needs to happen for this page to be more usable. And 3 icons long in 16:9 vs 2 icons long in 4:3 would be my suggestion. I know the Wii manages to fit 4x3 icons on 4:3 on their home screen, but I don't see where the space comes from... Maybe if the font was bigger, the icons could be smaller? But at that point, I feel we could also implement an entirely new list view mode, which is more like how both Homebrew Browser and the Wii Shop Channel did it.
App Details viewThis page struggles a lot more. With the SCALER's the font is sized better to fit, but as you pointed out it's hard to read at the small resolution. I think the best thing to do here is chop up the existing UI and make fonts larger. Also, I think that we should completely forgo the banner, as there's just not enough room for it, and OSC doesn't have a concept of them anyway. I'd say the goal for now isn't to make this page perfect, but at least clean up some of the overlapping icons, and tuck some sidebar information away behind a reveal button. It's kind of another candidate for a total rewrite...
Besides the title/icon/banner being re-arranged here, the sidebar would be completely tucked away behind the "Info" button, and pushing that would cause that information to be displayed coming in from the right-hand-side, in a larger font. The Back/Install buttons are changed to go alongside each other in a bottom-bar overlay. As for the inner content, it expands to the full width of the screen, but is otherwise the same as what it previously was, just without the sidebar restricting it. The Install button layout is kind of similar to the Wii Shop layout, with the bottom bar. I know this is kind of high-level feedback, but any steps in these directions I think would be big improvements. With a focus on text-readability and icon sizes not feeling out of place. |
Fixes UI Scaling but it's pretty hacky and the all details text is not readable (the app icon size is also very messed up)
This is very hacky but I'm open for suggestions to make it less hacky
I didn't scale the keyboard on search because I didn't figure out how to
Depends on fortheusers/chesto#2