fix(change_logs):add change logs entries for user update/create #140
Conversation
ChayanDass
force-pushed
the
change_logs_users
branch
from
8e164a6 to
e001138
Compare
ChayanDass
force-pushed
the
change_logs_users
branch
2 times, most recently
from
c0e40b2 to
75bc23b
Compare
pkg/auth/auth.go
Outdated
| updateActive := false | ||
| updatedUser.Active = &updateActive | ||
|
|
||
| if err := db.DB.Updates(&updatedUser).Error; err != nil { |
ChayanDass
force-pushed
the
change_logs_users
branch
from
75bc23b to
9e9e454
Compare
pkg/utils/util.go
Outdated
| AddChangelog("DisplayName", oldUser.DisplayName, newUser.DisplayName, &changes) | ||
| AddChangelog("UserEmail", oldUser.UserEmail, newUser.UserEmail, &changes) | ||
| AddChangelog("UserLevel", oldUser.UserLevel, newUser.UserLevel, &changes) | ||
| AddChangelog("UserPassword", oldUser.UserPassword, newUser.UserPassword, &changes) |
There was a problem hiding this comment.
Do not add password changes to changelogs. It will be a security issue.
There was a problem hiding this comment.
So should I totally remove the password field or add mask '****'. Else for password change logs will not create
There was a problem hiding this comment.
Totally remove it. Changing password should be a personal thing and logs shouldn't be generated for it.
There was a problem hiding this comment.
ok, i changed that and working as expected ...
ChayanDass
force-pushed
the
change_logs_users
branch
2 times, most recently
from
1dab160 to
91f42ff
Compare
|
Found error on testing. Internal server error on passing empty object to PATCH request: curl -X 'PATCH' }' |
ChayanDass
force-pushed
the
change_logs_users
branch
from
91f42ff to
12fb4a3
Compare
yes, done!
|
pkg/auth/auth.go
Outdated
| } | ||
| updatedUser.Id = olduser.Id | ||
| // update the user in the database | ||
| if err := tx.Clauses(clause.Returning{}).Updates(&updatedUser).Error; err != nil { |
There was a problem hiding this comment.
Clauses(clause.Returning{}) should be removed as we are fetching the updated user below anyhow?
ChayanDass
force-pushed
the
change_logs_users
branch
from
12fb4a3 to
8eb10ba
Compare
add changelogs for user updates and creation