Skip to content

Conversation

@its-sushant
Copy link
Contributor

Description

Add a agent for bm25Okapi agent.

Files

  • agents/bm25.py

How to use

  • Running bm25 agent
    atarashi -a bm25 /path/to/file.c

  • Checking accuracy using evaluator.py
    python3 path/to/evaluator.py -a bm25

Accuracy

The accuracy score that has been tested using evaluator.py is 62%

CC: @Kaushl2208 @GMishx @hastagAB @ag4ums @vasudevmaduri

@GMishx
Copy link
Member

GMishx commented Jul 17, 2022

Thank you for your contribution @its-sushant but the library rank-bm25 is Apache-2.0 licensed which is not compatible with GPL-2.0 license of Atarashi.

Please find an alternate of the library which is not GPL-3.0, Apache-* and AGPL-*.

@GMishx GMishx added enhancement New feature or request Wont-Fix This will not be worked on GSoC-22 bug Something isn't working and removed Wont-Fix This will not be worked on labels Jul 17, 2022
@hastagAB
Copy link
Member

Thank you for your contribution @its-sushant but the library rank-bm25 is Apache-2.0 licensed which is not compatible with GPL-2.0 license of Atarashi.

Please find an alternate of the library which is not GPL-3.0, Apache-* and AGPL-*.

@GMishx @its-sushant Can we implement BM25 algo in-house for Atarashi?

@its-sushant
Copy link
Contributor Author

Thank you for your contribution @its-sushant but the library rank-bm25 is Apache-2.0 licensed which is not compatible with GPL-2.0 license of Atarashi.
Please find an alternate of the library which is not GPL-3.0, Apache-* and AGPL-*.

@GMishx @its-sushant Can we implement BM25 algo in-house for Atarashi?

Sure, we can implement bm25 transformer itself in Atarashi. I have already started working on it and will revert the changes as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants