Update the dotnet-install script URL in Fake.DotNet.getGenericDotNetC… #2853
Conversation
| @@ -136,7 +136,7 @@ module DotNet = | |||
| /// Get .NET Core SDK download uri | |||
| /// </summary> | |||
| let private getGenericDotNetCliInstallerUrl branch installerName = | |||
| sprintf "https://raw.githubusercontent.com/dotnet/cli/%s/scripts/obtain/%s" branch installerName | |||
| sprintf "https://raw.githubusercontent.com/dotnet/install-scripts/%s/src/%s" branch installerName | |||
There was a problem hiding this comment.
I'm not really certain if this should be pulling the scripts from github or the 'distribution' urls such as https://dot.net/v1/dotnet-install.sh - but thats a bigger change which would mean dropping the configurable branch, so I just tried to keep it minimal for now
There was a problem hiding this comment.
We will be sharing guidance shortly.
This issue should provide some insight: dotnet/install-scripts#558 (comment)
xperiandri
force-pushed
the
install_script_url
branch
from
6490f68 to
94cd1aa
Compare
|
@Numpsy should I merge? |
I don't think that the existing URL is right (the script there doesn't contain the distribution domain update), but it might need a call on if 'branch' is really useful or if it should always use |
|
We don't guarantee prod-level stability/response with the GitHub URL. |
Numpsy
force-pushed
the
install_script_url
branch
from
94cd1aa to
600973f
Compare
…liInstallerUrl The scripts have been updated due to dotnet/core#9671, but according to https://github.com/dotnet/sdk/blob/main/scripts/obtain/dotnet-install-readme the source for the scripts was changed from https://github.com/dotnet/sdk to https://github.com/dotnet/install-scripts some years ago
xperiandri
force-pushed
the
install_script_url
branch
from
600973f to
af96cde
Compare
…liInstallerUrl
refs #2848
Description
The scripts have been updated due to dotnet/core#9671, but according to https://github.com/dotnet/sdk/blob/main/scripts/obtain/dotnet-install-readme the source for the scripts was changed from https://github.com/dotnet/sdk to https://github.com/dotnet/install-scripts some years ago, so it looks like FAKE was already using an old version of the scripts?