add tabix version #497
Open
add tabix version #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Nov 22, 2017
| @@ -2,7 +2,7 @@ | |||
| <description>multiple VCF datasets</description> | |||
|
|
|||
| <requirements> | |||
| <requirement type="package">tabix</requirement> | |||
| <requirement type="package" version="0.2.5">tabix</requirement> | |||
There was a problem hiding this comment.
Wouldn't it be better to use:
<requirement type="package" version="1.6">htslib</requirement>
instead? 0.2.5 is pretty ancient and tabix has been distributed as part of htslib for ages.
There was a problem hiding this comment.
I just try to fix the old package. The multicontainer builds are failing because of this. Thats also the reason I have not bumped the tool version number.
Is this ok for you?
There was a problem hiding this comment.
That's not the only problematic requirement in this tool collection:
tool_collections/vcftools/vcftools_annotate/vcftools_annotate.xml
5: <requirement type="binary">echo</requirement>
tool_collections/vcftools/vcftools_isec/vcftools_isec.xml
5: <requirement type="package">tabix</requirement>
tool_collections/vcftools/vcftools_merge/vcftools_merge.xml
5: <requirement type="package">tabix</requirement>
tool_collections/vcftools/vcftools_slice/vcftools_slice.xml
5: <requirement type="binary">echo</requirement>
tool_collections/vcftools/vcftools_subset/vcftools_subset.xml
5: <requirement type="package">tabix</requirement>
Also, tool_collections/vcftools/vcftools_consensus/vcftools_consensus.xml is already using htslib to provide tabix:
<requirement type="package" version="1.3.2">htslib</requirement>
Finally, I noticed that:
- only
vcftools_consensuscites10.1093/bioinformatics/btr330 - documentation links in
<help>could be updated to https://vcftools.github.io/examples.html .
The upstream vcftools seems to be maintained, so it may be worth to use a more sustainable solution?
|
xref. #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.