[TESTS] Add tests for the s3 module
#150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteOtter
changed the title
s3 modules3 module
ByteOtter
force-pushed
the
tests/add-s3-tests
branch
from
647f990 to
44b2c48
Compare
ByteOtter
force-pushed
the
tests/add-s3-tests
branch
2 times, most recently
from
245873d to
1edbb89
Compare
* Use fixture with mock_aws context manager instead of directly patching Bucket
ByteOtter
force-pushed
the
tests/add-s3-tests
branch
from
1edbb89 to
a4190b9
Compare
NotTheEvilOne
requested changes
Jul 31, 2025
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In order to improve test coverage - and therefore reliability of our code - this PR adds unittests to the
src/gardenlinux/s3module.Which issue(s) this PR fixes:
Fixes #122
Tracks #138
Special notes for your reviewer:
This PR introduces a new dev-dependency:
motoThis dependency mocks an AWS environment and allows for testing of our
boto3code.Once merged, it could be that there is a conflict with #142 due to changes to the
pyproject.toml. This is easily fixed though.Currently,
pytestcatches a deprecation warningDeprecationWarning: datetime.datetime.utcnow()though this most likely comes frommotoand will be fixed upstream in the future.Release note: