-
Notifications
You must be signed in to change notification settings - Fork 2
CI: Improve actions/setup
workflow
#156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Improve actions/setup
workflow
#156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should support outputs for this action. E.g.:
outputs:
cache_type:
description: "Detected Python cache strategy."
value: ${{ steps.lockfile.outputs.cache_type }}
* Check for existing python installation before installing new * Base caching method on found lockfile type
eb7c16d
to
967d5ef
Compare
* Format Code * Combine cache type evaluation and installation verification into one * Expose cache_type as output to invoked actions
Did just that with the latest commit. |
If I remember correctly each GitHub runner has an |
Hmm I think in that case we should remove that skipping of |
Currently encountering this error right here:
Which means that at the point |
Different from |
57391bf
to
d3a8901
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 63.00% 63.00%
=======================================
Files 27 27
Lines 1192 1192
=======================================
Hits 751 751
Misses 441 441 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tobias Wolf <[email protected]>
d3a8901
to
8759217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Expands the existing
setup
actions with logic that skips python installation when python is already installed and sets the caching method depending on the lockfile type (pip
forrequirements.txt
andpoetry
forpoetry.lock
; If no lockfile is found, an emptyrequirements.txt
is created and caching type set topip
)Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: