Type checking for propagate kwargs. #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type testing for some kwargs in
propagate, and adjusted a test that I think was already failing because of a wrong type but now it no longer fails quietly.This is basically the same as #126, but applied to the changes of #132 (where an extra kwarg was introduced) and with a fix of the test.
Unfortunately is seems that the changes are triggering the failing of some other tests. I think the problem is that now, in case
keep_deltas isa Val{true}butkeep_triples isa Val{false},propagatesometimes returns aDualtype instead of aStochasticTripletype. The test expects the latter though. I'm not entirely sure what the intended behavior is though so I won't make any further changes without further discussion.