Remove docker-compose down b/c it is not needed and adds downtime #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toome123
pushed a commit
to toome123/IOTstack
that referenced
this pull request
Dec 4, 2020
…v-template Use only known-good keys in InfluxDB environment template
|
I noticed this yesterday also, took docker down while it was running, was unexpected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker update process can be performed with the containers active. The
docker-compose upprocess automatically replaces any old container, even if it is still active. This means that there is nearly zero downtime.So instead of shutting contains down before pulling and building updates (a lengthy process), the current containers can continue performing tasks, only being replaced when any updates have finished being processed.
The
docker-compose buildline could also be integrated into the up process via a flag:docker-compose up -d --build, however, that may obscure the flow of things hence I didn't propose it.