Skip to content

Fix: Ping pong #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: Ping pong #135

wants to merge 3 commits into from

Conversation

shreyshreyansh
Copy link
Contributor

Fixes #133

Screenshot 2021-08-17 123814

Copy link
Owner

@geekymeeky geekymeeky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the above-mentioned changes, these are the following changes that must be addressed:

  • Add single-player mode to the game.


</html>
<style>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly add styles to pingpong.css file

</h1>
</div>
<script>
let gameState = "start";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add javascript to pingpong.js file

transition: transform .5s;
.memory-card {
width: calc(25% - 10px);
/*calc remove the margin area form the width*/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create separate PRs for each issue concerned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canvas is too large in ping pong table(unable to see the ball)
2 participants