fix: use own cdp implementation #1129
Conversation
KuznetsovRoman
force-pushed
the
TESTPLANE-693.cdp
branch
2 times, most recently
from
8cc1b46 to
1223919
Compare
commit: |
KuznetsovRoman
force-pushed
the
TESTPLANE-693.cdp
branch
4 times, most recently
from
9232a6d to
56b81a4
Compare
| "vite": "5.1.6", | ||
| "wait-port": "1.1.0", | ||
| "worker-farm": "1.7.0", | ||
| "ws": "8.18.3", |
There was a problem hiding this comment.
using this version because we already have it as "@testplane/[email protected]" dependency
| import * as logger from "../../utils/logger"; | ||
| import { EventEmitter } from "events"; | ||
|
|
||
| export class CDPEventEmitter<Events extends { [key in keyof Events]: unknown }> extends EventEmitter { |
There was a problem hiding this comment.
This class provides typings for eventemitter, like that:
Also it wraps callbacks so they don't produce unhandled rejection
| public readonly profiler: CDPProfiler; | ||
|
|
||
| static async create(browser: Browser): Promise<CDP | null> { | ||
| if (!browser.publicAPI.isChromium) { |
There was a problem hiding this comment.
cdp is only available in chromium-based browsers
| import { CDPEventEmitter } from "./emitter"; | ||
| import type { CDPDebuggerLocation, CDPSessionId, CDPScriptCoverage, CDPProfile } from "./types"; | ||
|
|
||
| interface StartPreciseCoverageRequest { |
There was a problem hiding this comment.
copied typings from https://chromedevtools.github.io/devtools-protocol/1-3/Profiler/
| return new Promise(resolve => setTimeout(resolve, delay).unref()); | ||
| }; | ||
|
|
||
| export const extractRequestIdFromBrokenResponse = (message: string): number | null => { |
There was a problem hiding this comment.
as we have seen, we might get broken message, which can't be parsed with json.parse
This function extracts request "id", so we can stop waiting for response for it until timeout and just retry it
| * @description creates ws connection with retries or returns existing one | ||
| * @note Concurrent requests with same params produce same ws connection | ||
| */ | ||
| private async getWsConnection(): Promise<WebSocket> { |
There was a problem hiding this comment.
Retries "tryToEstablishWsConnection"
| } | ||
|
|
||
| /** @description establishes ws connection, sends request with timeout and waits for response */ | ||
| private async tryToSendRequest( |
There was a problem hiding this comment.
Makes single try to send a request and resolves its response
| } | ||
|
|
||
| /** @description Performs high-level CDP request with retries and timeouts */ | ||
| async request<T>( |
There was a problem hiding this comment.
retries "tryToSendRequest"
| /** @description Closes websocket connection, terminating all pending requests */ | ||
| close(): void { |
There was a problem hiding this comment.
Should only be called once, when we would not need this connection in the future (for example, when deleting browser session)
| if (!this.isWebSocketActive(ws)) { | ||
| clearInterval(pingInterval); | ||
| return; | ||
| } |
There was a problem hiding this comment.
on each tick we have to check it first, because we might catch a frame where this callback is called when this pingInterval is no longer active because ws connection is reestablished
KuznetsovRoman
force-pushed
the
TESTPLANE-693.cdp
branch
2 times, most recently
from
fc679c0 to
0805224
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-693.cdp
branch
from
0805224 to
0e0c4ed
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-693.cdp
branch
from
0e0c4ed to
641a566
Compare
No description provided.