Skip to content

Improve observability components and documentation #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve observability components and documentation #1001

wants to merge 2 commits into from

Conversation

iroqueta
Copy link
Collaborator

@iroqueta iroqueta commented Aug 8, 2025

  1. Add comprehensive README.md for gxobservability module with overview, features, and usage examples
  2. Enhance GXSpanContextTest with a more robust test for the default constructor:
    • Create a controlled testing environment with SdkTracerProvider
    • Set up a span with known trace and span IDs
    • Make it the current span and verify that GXSpanContext captures it correctly
    • Validate exact trace and span ID values instead of just structure
  3. Add unit tests for all core components:
    • GXTraceContextTest
    • OtelSpanTest
    • OtelTracerTest
  4. Update implementation files with improved code documentation and error handling
  5. Enhance OpenTelemetryHelper with better exception handling and documentation

@iroqueta
Improve observability components and documentation
d856f36 
1. Add comprehensive README.md for gxobservability module with overview, features, and usage examples
2. Enhance GXSpanContextTest with a more robust test for the default constructor:
   - Create a controlled testing environment with SdkTracerProvider
   - Set up a span with known trace and span IDs
   - Make it the current span and verify that GXSpanContext captures it correctly
   - Validate exact trace and span ID values instead of just structure
3. Add unit tests for all core components:
   - GXTraceContextTest
   - OtelSpanTest
   - OtelTracerTest
4. Update implementation files with improved code documentation and error handling
5. Enhance OpenTelemetryHelper with better exception handling and documentation
@iroqueta iroqueta requested a review from sjuarezgx August 8, 2025 18:54
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@iroqueta
Add extractAttributeValue testing capabilities
a872ee0 
1. Create ExtractAttributeValueHelper class to expose attribute extraction functionality
   with a clean public API for testing purposes
2. Implement comprehensive ExtractAttributeValueTest with test cases for:
   - Null parameters handling
   - Empty string handling
   - Simple key-value extraction
   - Multiple attribute extraction
   - Non-existent attribute handling
3. Update OtelTracerTest to include reflection-based testing approach
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjuarezgx sjuarezgx Awaiting requested review from sjuarezgx

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iroqueta @genexusbot